Page 1 of 2

Wrong suggestion

Posted: Tue Jun 22, 2010 2:32 pm
by inoam
Hi!
Using Hebrew is a pleasure and that's why I bought the keyboard for. The suggestion are written from left to write instead of from right to left.

Here is some information:
http://code.google.com/p/cyanogenmod/is ... il?id=1673

Thanks a lot!

Re: Wrong suggestion

Posted: Tue Jun 22, 2010 3:06 pm
by cyril
Hi
That's why I added an option "RTL suggestions" in v2.5.0 (it was for arabic, but it also applies to hebrew)
The point is that some ROMs implement RTL correctly, others don't, so the keyboard cannot guess automatically what it has to do (unless someone has a magical idea). That's why there is an option ;)

Re: Wrong suggestion

Posted: Tue Jun 22, 2010 5:43 pm
by inoam
Thanks Cyril that's great, didn't know about this option! I'll let the community know...
Tried it now, it works but only for the word typed the rest are still switched...

Re: Wrong suggestion

Posted: Tue Jun 22, 2010 6:11 pm
by cyril
Tried it now (again), and it works for all the words ;) So I don't understand...

Re: Wrong suggestion

Posted: Wed Jun 23, 2010 8:25 am
by inoam
Cyril are you using cyanogen 5.0.8? I can send you a screen shot of that would help, also I confirmed this issue with other people using hebrew on smartkeyboard pro.

Re: Wrong suggestion

Posted: Wed Jun 23, 2010 8:39 am
by cyril
No, I am using FRF50 at the moment, but when I uncheck this option, all the words appear reverse, so I would expect the contrary on CM.
I don't really understand why the highlighted word would have a different behavior in CM, as all the words in the suggestion bar are written with Canvas.drawText() method

Re: Wrong suggestion

Posted: Wed Jun 23, 2010 11:00 am
by inoam
Sorry I can't tell you why... but I do know that bidi is handled differently in cyanogenmod (recently it was patched to solve bidi issues in android).
Also I found the relevant code. Hope it helps...

http://github.com/cyanogen/android_fram ... 27d9aa0ba7

Re: Wrong suggestion

Posted: Wed Jun 23, 2010 11:27 am
by inoam
Also, found this: http://code.google.com/p/softkeyboard/i ... ?id=66#c28
I think it would help you solve the problem.

Re: Wrong suggestion

Posted: Tue Jun 29, 2010 12:54 pm
by inoam
Hey Cyril and progress on the Issue?
Also, just reporting a small bug, long pressing "ש" to get "0" gives out something else.

Re: Wrong suggestion

Posted: Tue Jun 29, 2010 1:01 pm
by cyril
No... I would need to flash CM (I don't have time at the moment) to check this problem myself, because I can't understand how that's possible
About the long press, it's on purpose.. it displays a 0 and another character (I don't know why but I saw that on other keyboards too ;) )